Rename BlockedSlice from #459 to NoncontiguousBlockSlice
#479
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…BlockIndexRange as alias
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #479 +/- ##
==========================================
+ Coverage 93.81% 94.11% +0.30%
==========================================
Files 19 19
Lines 1761 1768 +7
==========================================
+ Hits 1652 1664 +12
+ Misses 109 104 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Can you get the codecov up? |
Yes, will do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is split off from #462, it renames
BlockedSliceintroduced in #459 toNoncontiguousBlockSliceand also adds more functionality and tests so that it is as featureful asBlockSlice. The reason for the name change is that in #462, this type will be used in slicing operations such asV[[Block(1), Block(3)]]andV[Block(1)[[1, 3]]]. In my opinion,BlockedSlicedoesn't make a lot of sense as a name for the latter case. The more general concept is that it is a slice object constructed when there is a non-contiguous blockwise slice of some form (either non-contiguous blocks or non-contiguous within a block).I'm open to other name suggestions,
NoncontiguousBlockSliceis the best I could come up with and there isn't really an analogous case for this in Base from what I've seen. Note the main reason why we can't just useBlockSlicefor those cases is thatBlockSliceis anAbstractUnitRangesubtype andNoncontiguousBlockSlicecovers cases where the slices aren't ranges, so maybeBlockSliceVectorcould work as a name to emphasize that point.