-
Notifications
You must be signed in to change notification settings - Fork 30
Move SparseArrays dependency to extension #365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #365 +/- ##
==========================================
- Coverage 95.72% 0.00% -95.73%
==========================================
Files 17 18 +1
Lines 3208 3167 -41
==========================================
- Hits 3071 0 -3071
- Misses 137 3167 +3030 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
"my_" is a very bad naming convention. I have no idea what these are for! |
Well the idea is to have some issparse and nnz methods which defaults to false in the case SparseArrays is not loaded, and is extended with the ones from SparseArrays in the extensions. Do you agree with the general approach ? Instead of "my_" we could use "", "tentative" "local_" "provisional_" "preliminary_" ... |
@j-fu I think |
I think even just beginning with |
But we would need a comment explaining the design |
It is sufficient to define a method for `Any` in the package, and for `AbstractArray` in the SparseArrays extension. Other dispatches are already implemented in SparseArrays.
Review from Copilot/GPT5:
|
If you bump the minor version (1.x) I can merge and tag |
This should help to resolve SciML/LinearSolve.jl#573