Update to the latest broadcast implement. #284
+52
−38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
N5N3
force-pushed
the
newbc
branch
2 times, most recently
from
503a227 to
b8024dd
Compare
On master `Broadcasted` store style by field. Update accordingly.
|
I personally don't understand the motivation, what problems exactly does it solve? |
|
It should make parent broadcast style with metadata happier. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On master
Broadcastedstore style by field. Update accordingly.Test for parent
BroadcastStylewith field meta has not been added.Just run CI to make sure the code works on old julia.