-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
speed up large polygon intersections using STRtrees. #259
Open
asinghvi17
wants to merge
47
commits into
as/stabletasks
Choose a base branch
from
as/non_working_do_everything
base: as/stabletasks
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@rafaqz this is where I want to make it super easy to have a DimMatrix of benchmarks, to test scaling dynamics.... |
- Move STRDualQuery and the utils to utils/ - Create a new module LoopStateMachine that just defines some actions, and a macro @processloopactions that you can use to break out of a loop if you want, in a `map_some_things(f1, f2, f3, ...)`. Add tests for LoopStateMachine Use LoopStateMachine in the maybe function I added to clipping processor
I just realized, the tests aren't actually testing anything :D |
* lay off 3/4 of the testsets this uses the ContextTestSet from Test to reduce the amount of visual cruft. It doesn't reduce it all the way but it can help. Next step is to have a custom testset that can elide the excessive display. * print better context * also test densified geoms
See #260 for the testset diff |
Seems the densified module isn't actually testing anything... |
This is a bit more global than it should be, but it's probably fine...
This is the simplest possible implementation for a catch-all multipolygontrait setup and we should probably port this to all the functions, to decrease complexity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses STRtrees to substantially accelerate polygon queries. It pulls the actual looping all the way out and allows the use of STRtrees to skip substantial sections of polygons.
There are three methods here:
This algorithm should be easily portable to s2 when that becomes available - and the structure allows e.g. manifold passthrough as well.

This PR also adds a LoopStateMachine module that basically just defines an
Action
wrapper struct, and a macro that can take care of that action wrapper struct.With this macro, a function running within a loop can return
Break()
orContinue()
which indicates to the caller that it should break or continue.E.g.:
TODOs: