Skip to content

Conversation

nhz2
Copy link
Member

@nhz2 nhz2 commented Oct 5, 2025

Fixes #79

This PR adds support for the windowLog compression parameter and the windowLogMax decompression parameter.

This corresponds to the --long[=#] cli option, and is required to read certain zstd files.

XRef: https://discourse.julialang.org/t/decompression-of-large-files/132191

@nhz2 nhz2 requested a review from mkitti October 5, 2025 03:21
Copy link

codecov bot commented Oct 5, 2025

Codecov Report

❌ Patch coverage is 89.79592% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 64.19%. Comparing base (bce7567) to head (e9379ae).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/compression.jl 88.46% 3 Missing ⚠️
src/decompression.jl 91.30% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #82      +/-   ##
==========================================
+ Coverage   61.18%   64.19%   +3.00%     
==========================================
  Files           4        4              
  Lines         353      391      +38     
==========================================
+ Hits          216      251      +35     
- Misses        137      140       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@mkitti mkitti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we going to need to do this for all of the parameters eventually?

This can go ahead, but I want to think of about the overall strategy to cover all of the parameters.

@nhz2
Copy link
Member Author

nhz2 commented Oct 5, 2025

I think the less commonly needed and experimental parameters could use something like in #73 or https://github.com/JuliaIO/ChunkCodecs.jl/blob/c1e9c01e531a29c9bb554d7a93e7e57ecd4b3045/LibZstd/src/encode.jl#L21-L30

windowLog is a bit special because it benefits from specific error handling and docs.

@nhz2 nhz2 merged commit b9630e6 into master Oct 5, 2025
18 checks passed
@nhz2 nhz2 deleted the nz/more-parameters branch October 5, 2025 14:37
@nhz2 nhz2 mentioned this pull request Oct 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow setting ZSTD_d_windowLogMax decompression parameter

2 participants