-
Notifications
You must be signed in to change notification settings - Fork 29
updates for JSON v1 #222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updates for JSON v1 #222
Conversation
mkitti
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How long do you think we need the AWS.jl fork?
until JuliaCloud/AWS.jl#741 is merged and patch released 😄 |
|
should we add |
|
Would AWS.jl make sense as an optional dependency via a package extension? |
Pull Request Test Coverage Report for Build 19541885018Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
yes, next we will put all |
|
If this works, I am good to merge and release this. |
|
Yes, I would also merge the JSON v1 updates for now and then we can move AWS-related things to an extension in a follow-up PR. |
this PR includes all the necessary updates for JSON V1.
For now, I’ve added my own AWS branch, which also needed some updates to make this work.
All tests passed for me locally, let's see how CI behaves.
Merging and patching here should be done after JuliaCloud/AWS.jl#741 is also merged and patch released.