Skip to content

Conversation

@lazarusA
Copy link
Contributor

this PR includes all the necessary updates for JSON V1.

For now, I’ve added my own AWS branch, which also needed some updates to make this work.

All tests passed for me locally, let's see how CI behaves.

Merging and patching here should be done after JuliaCloud/AWS.jl#741 is also merged and patch released.

Copy link
Member

@mkitti mkitti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How long do you think we need the AWS.jl fork?

@lazarusA
Copy link
Contributor Author

lazarusA commented Nov 16, 2025

How long do you think we need the AWS.jl fork?

until JuliaCloud/AWS.jl#741 is merged and patch released 😄

@lazarusA
Copy link
Contributor Author

should we add AWS to the compats main project.toml ? @meggart

@mkitti
Copy link
Member

mkitti commented Nov 17, 2025

Would AWS.jl make sense as an optional dependency via a package extension?

@coveralls
Copy link

coveralls commented Nov 20, 2025

Pull Request Test Coverage Report for Build 19541885018

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 5 of 6 (83.33%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 89.309%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/Storage/gcstore.jl 0 1 0.0%
Totals Coverage Status
Change from base Build 19048552340: 0.01%
Covered Lines: 969
Relevant Lines: 1085

💛 - Coveralls

@lazarusA
Copy link
Contributor Author

Would AWS.jl make sense as an optional dependency via a package extension?

yes, next we will put all AWS related stuff into an extension.

@mkitti
Copy link
Member

mkitti commented Nov 20, 2025

If this works, I am good to merge and release this.

@meggart
Copy link
Collaborator

meggart commented Nov 20, 2025

Yes, I would also merge the JSON v1 updates for now and then we can move AWS-related things to an extension in a follow-up PR.

@meggart meggart merged commit 9e74750 into JuliaIO:master Nov 20, 2025
14 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants