Skip to content

Fix sin_rev and cos_rev#34

Open
dpsanders wants to merge 1 commit intomasterfrom
fix_sin_and_cos
Open

Fix sin_rev and cos_rev#34
dpsanders wants to merge 1 commit intomasterfrom
fix_sin_and_cos

Conversation

@dpsanders
Copy link
Copy Markdown
Member

No description provided.

@lucaferranti
Copy link
Copy Markdown
Member

@lbenet @dpsanders I rebased this, but it seems it breaks a bunch of IEEE tests for sin and cos

@lucaferranti
Copy link
Copy Markdown
Member

I'm also surprised that sin_rev(0..0, 0..0) wasn't a test in the IEEE testsuite, it feels like an important corner case

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants