-
-
Notifications
You must be signed in to change notification settings - Fork 116
add @__FUNCTION__
macro
#841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@martinholters let me know if you have any comments. I'm eager to get this merged as I need it in a package |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the restrictions mentioned in the docstring will go largely unnoticed. Maybe add a sentence to the README, pointing to the docstring for details?
Co-authored-by: Martin Holters <[email protected]>
Thanks, done! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #841 +/- ##
===========================================
+ Coverage 50.00% 91.78% +41.78%
===========================================
Files 2 2
Lines 458 487 +29
===========================================
+ Hits 229 447 +218
+ Misses 229 40 -189 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@martinholters sorry for pinging but just wanted to check-in on this (usually I only have time to code on the weekend these days) |
JuliaLang/julia#58940
The macro implemented here differs slightly because it needs to refer to the internal variable
var"#self#"
, rather than the newExpr(:thisfunction)
directive, as the later required parser changes to expand compatibility with callable structs.However, the only change this means in practice is that the Compat version will throw an error in cases where the Julia 1.13.0-DEV.880 version would work. So there would not be any silent differences; only very obvious ones. I have mentioned these cases on the Compat version docstring.