RFC: stack(::Slices)
is permutedims
#47554
Open
+28
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some operations on
Slices
from #32310 can be more efficiently done on the parent array. Should we add shortcuts, and how widely? The obvious candidate is reductions but the problem is this:and (edit) another problem is this:
This PR tries something which seems safer, sending
stack(eachslice(x))
topermutedims
. Not always much of a speed improvement, but sometimes it is:Draft, needs tests, and possibly located in the wrong file.
Possibly introduces type-instabilities in its present form. It would be nicer if this could dispatch on the type of
Slices
to know whether or not it can usepermutedims
, but as far as I can see it cannot.