Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move out LinearAlgebra into its own repository #56637

Merged
merged 2 commits into from
Nov 24, 2024
Merged

Conversation

KristofferC
Copy link
Member

@KristofferC KristofferC commented Nov 21, 2024

This moves out LinearAlgebra into its own repo https://github.com/JuliaLang/LinearAlgebra.jl. This repo is still a bit bare (README needs to be added) but it has CI set up to run on buildkite (https://buildkite.com/julialang/linearalgebra-dot-jl/builds/18) and doc building on GHA. The external repo has all commits up to 4709b6c included in it.

The reason for the move is to be able to focus issues and PRs and development regarding LinearAlgebra in one place.

@KristofferC KristofferC added the excision Removal of code from Base or the repository label Nov 21, 2024
@ViralBShah
Copy link
Member

So I assume we should hold on merging any linalg PRs in the main julia repo now, right? Issues can be transferred - but do we just close all the linalg PRs?

Co-authored-by: Sergio Sánchez Ramírez <[email protected]>
@IanButterworth
Copy link
Member

Screenshot 2024-11-22 at 9 18 46 AM
Shame github has stopped showing lines removed on https://github.com/JuliaLang/julia/graphs/contributors

@KristofferC
Copy link
Member Author

Heyy, when did they remove that :(

@IanButterworth
Copy link
Member

I heard about it on the Julia Dispatch Podcast #ad

@nsajko nsajko added the linear algebra Linear algebra label Nov 23, 2024
@KristofferC KristofferC merged commit e5e7be2 into master Nov 24, 2024
8 checks passed
@KristofferC KristofferC deleted the kc/move_out_LA branch November 24, 2024 18:44
@gitboy16
Copy link
Contributor

Hi, might be a dumb question but I was wondering if there is a way to build Julia without LinearAlgebra? More generally speaking is there a mechanism to choose which library to include or exclude while building Julia?

@giordano
Copy link
Contributor

giordano commented Nov 26, 2024

Heyy, when did they remove that :(

I'm pretty sure it was since one year ago, they announced it on the blog, can't find the post now though. Edit: here it is: https://github.blog/changelog/2023-11-29-upcoming-changes-to-repository-insights/

@ViralBShah
Copy link
Member

ViralBShah commented Dec 2, 2024

Should we turn off LinearAlgebra testing for every commit on the Julia repo now? Is there a way to run it much more selectively, or only when LinearAlgebra PRs are merged?

Maybe a possible way to do this is for BumpStdlibs.jl PRs to run the testsuite for all stdlibs (but not julia compiler/runtime tests).

@DilumAluthge Thoughts?

@IanButterworth
Copy link
Member

IanButterworth commented Dec 2, 2024

Could we run it as a regular GitHub action test on Linux only, like we do for Revise (but not on the buildkite system)? That way it's in parallel so should still have the same effect of speeding up CI, but less chance of regression.

@ViralBShah
Copy link
Member

Even so - the full LinearAlgebra testsuite is overkill - but that is a separate issue being discussed in JuliaLang/LinearAlgebra.jl#1117.

@KristofferC
Copy link
Member Author

KristofferC commented Dec 2, 2024

I suggested running it when:

  • The LinearAlgebra.version file is changed.
  • On backports and release branches.

@DilumAluthge
Copy link
Member

@fatteneder has been doing some work on filtering tests based on the contents of the PR. See e.g. JuliaCI/julia-buildkite#400

I'd suggest that we first finish up JuliaCI/julia-buildkite#400 and get that merged, and then the next step will be to build the "only run stdlib tests sometimes" functionality on top of the functionality in JuliaCI/julia-buildkite#400.

@DilumAluthge
Copy link
Member

Here's a tracking issue: JuliaCI/julia-buildkite#411

@waldyrious
Copy link
Contributor

waldyrious commented Jan 1, 2025

Just for historical reference: this PR closed issue #22698, "Move LinearAlgebra to its own repo" (which now lives at JuliaLang/LinearAlgebra.jl#446).

† Or would have, if it hadn't been preemptively closed 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
excision Removal of code from Base or the repository linear algebra Linear algebra
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants