Fix error message when using const inside a function, require the LHS to be global, and prohibit "const x[] = 1"

[xal-0]

The changes to const resulted in confusing error messages when it was used
inside a function (#57334). On 1.11.3:

julia> function f()
           const x = 1
       end
ERROR: syntax: unsupported `const` declaration on local variable around REPL[1]:2
Stacktrace:
 [1] top-level scope
   @ REPL[1]:1

On nightly:

julia> function f()
           const x = 1
       end
ERROR: syntax: World age increment not at top level
Stacktrace:
 [1] top-level scope
   @ REPL[1]:1

In prior versions, we also accepted confused expressions like:

x = Ref(1)
const x[] = 1

This change adds a new error messages explicitly prohibiting const where the
left hand side is not declaring variables:

ERROR: syntax: `const` left hand side "x[]" contains non-variables around REPL[2]:1
Stacktrace:
 [1] top-level scope
   @ REPL[2]:1

Finally, #54773 made const stop participating in scope resolution (the left
hand side was always taken to be in global scope). Some expressions that were
prohibited started being accepted:

In 1.11.3:

julia> let
           const x = 1
       end
ERROR: syntax: unsupported `const` declaration on local variable around REPL[1]:2
Stacktrace:
 [1] top-level scope
   @ REPL[1]:1

Nightly:

julia> let
           const x = 1
       end
1

This change rejects const unless the variable would be in global scope
(global const would be required in the example), so we don't lose the
ability to make const in local scope meaningful later.

[vtjnash]

LGTM. Minor nit with this error though:

julia> const (x{T},) = T
ERROR: syntax: `const` left hand side "SSAValue(81)" contains non-variables around REPL[13]:1

[xal-0]

Argh, this is actually a regression.

1.11.3:

julia> const X{T}, Y{U} = [Int, Int]
2-element Vector{DataType}:
 Int64
 Int64

This:

julia> const X{T}, Y{U} = [Int, Int]
ERROR: syntax: `const` left hand side "SSAValue(4)" contains non-variables around REPL[1]:1
Stacktrace:
 [1] top-level scope
   @ REPL[1]:1

I'll need to think of a way to handle this.

[xal-0]

This is a note to myself to not squash 9fe9bbe so I am not git blame'd for all of the assignment lowering code.

[xal-0]

@nanosoldier runtests()

[mlechu]

Linking #25642

[nanosoldier]

The package evaluation job you requested has completed - possible new issues were detected.
The full report is available.

Report summary

❗ Packages that crashed

1 packages crashed only on the current version.

• An internal error was encountered: 1 packages

13 packages crashed on the previous version too.

✖ Packages that failed

24 packages failed only on the current version.

• Package fails to precompile: 1 packages
• Package has test failures: 1 packages
• Package tests unexpectedly errored: 1 packages
• Test duration exceeded the time limit: 21 packages

1109 packages failed on the previous version too.

✔ Packages that passed tests

27 packages passed tests only on the current version.

• Other: 27 packages

5330 packages passed tests on the previous version too.

~ Packages that at least loaded

7 packages successfully loaded only on the current version.

• Other: 7 packages

2926 packages successfully loaded on the previous version too.

➖ Packages that were skipped altogether

899 packages were skipped on the previous version too.

[KristofferC]

Is https://s3.amazonaws.com/julialang-reports/nanosoldier/pkgeval/by_hash/ce76dbf_vs_095fc99/PackageMaker.primary.log caused by this?

[mlechu]

Suggested change

	(if (length= e 2) (null) `(= ,@(cdr e)))
	(if (length= e 2) (null) (resolve-scopes- `(= ,@(cdr e)) scope sp loc))

would fix #57574 (suggested here since you've already done this to the other branch).