-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
REPL: call display on the backend #57773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
REPL: call display on the backend #57773
Conversation
Though I think handling errors in
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Branching on whether the parser returned an Expr or a Function seems somewhat unwise, but otherwise the PR seems a good direction
ddd9e16
to
8d77b53
Compare
8d77b53
to
424a5ce
Compare
(cherry picked from commit c75cf3f)
(cherry picked from commit c75cf3f)
I think this broke Debugger.jl.
This is what Debugger does: https://github.com/JuliaDebug/Debugger.jl/blob/6a6beab2f559a5a72d3284c1c6482e0620026db8/src/repl.jl#L194. Should it be changed somehow? |
@KristofferC I believe this is fixed by JuliaDebug/Debugger.jl#366 (but I would appreciate review since the intent here is highly unclear) |
I think the fix should be to figure out and fix why it's hanging, not avoid that method. But I haven't had time to look into this yet. I don't have any breadcrumbs right now, sorry. |
should we revert the backport to 1.11? This is in 1.11.5 (already released), and breaking Debugger is pretty bad... |
I think we just need to async call print_response and wait for it |
Fixes #57742
With this PR (The last 2 are pasted in in one operation)