macrocall: Specialize macro invocations like normal function calls #57782
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`jl_invoke` behaves like `Expr(:invoke, ...)` not `Core.invoke`, so we were (accidentally?) bypassing the default specialization for a `macro` and only ever invoked de-specialized MethodInstances. Change this to `jl_apply` so that we specialize as normal, which should dramatically improve inference and not lead to much extra code since our AST is very homogeneous (`Expr` + typeof.(literals), IIUC)
topolarity
force-pushed
the
ct/specialize-macrocall
branch
from
dfdd613 to
75c3101
Compare
topolarity
added
backport 1.10
That was sort of the point though, since inference is supposed to reject these also anyways, so attempted specialization here is expected to be just wasted effort |
Why the invalidations in #57781 then? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by #57781 (kudos to @nsajko for another good find)
jl_invokebehaves likeExpr(:invoke, ...)notCore.invoke, so this was bypassing the default specialization for amacroand only ever invoked de-specialized MethodInstances.Change this to
jl_applyso that we specialize as normal, which should dramatically improve inference and not lead to much extra code since our AST is very homogeneous (Expr+ typeof.(literals), IIUC).