macrocall: Specialize macro invocations like normal function calls #57782
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by #57781 (kudos to @nsajko for another good find)
jl_invoke
behaves likeExpr(:invoke, ...)
notCore.invoke
, so this was bypassing the default specialization for amacro
and only ever invoked de-specialized MethodInstances.Change this to
jl_apply
so that we specialize as normal, which should dramatically improve inference and not lead to much extra code since our AST is very homogeneous (Expr
+ typeof.(literals), IIUC).