Bump LLVM to v21 #59950
Draft
Bump LLVM to v21 #59950
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giordano
added
building
We already need to manually create a C compatible function pointer and heap allocated data, might as well do so directly without another indirection through std::function.
Turn `add_output` into a manual co-routine so that we can get out of the caller scope mid-call to release the threadsafecontext lock early.
Member
Author
|
Oh, cool, with the changes in #59946 temporarily incorporated here, for the platforms where compilation is successful (macos and freebsd) tests are already passing, that's encouraging. |
Contributor
|
The compile error on linux seems to be a Werror for uninitialized variable in LLVM. It could easily be a false positive since it's in the part of the code where LLVM does it's trick with memory layout of objects... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I won't be able to work on this besides for rebasing the PR and other small edits, I'm opening this PR to keep the ball rolling, but everyone is more than welcome to take it over.
This needs #59946 to start with.