Skip to content

Remove unless size check in Memory allocation #59992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Remove unless size check in Memory allocation #59992

wants to merge 2 commits into from
+3 −3

Conversation

@yuyichao
Copy link
Contributor

Reapply half of #59971.

The check is unnecessary/confusing since emit_const_len_memorynew already does better check with proper user error message.

@DilumAluthge DilumAluthge added the re-land This relands a PR that was previously merged but was later reverted. label Oct 29, 2025
@fingolfin
Copy link
Member

"Remove unless size check" -> "Remove useless size check" ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vtjnash vtjnash vtjnash approved these changes

Assignees

@vtjnash vtjnash

Labels

re-land This relands a PR that was previously merged but was later reverted.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@yuyichao @fingolfin @vtjnash @DilumAluthge