Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a comeback of the ancient
obsdim
argument, in a simplified fashion.In this new reincarnation, we don't require all functions in the library to deal with an
obsdim
argument, e.g.numobs
andgetobs
have no knowledge ofobsdim
.If users want to work with a non-standard (i.e. non-last) observation dimension for arrays, they wrap their data with
obsview(data, obsdim)
at the beginning of the pipeline, and then they forget aboutobsdim
in the following transformations. This has been previously discussed here.Since the
slidingwindow
method could be dealing often with non-standard obsdim (time), I add the argument also there. Close #199