Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add obsdim argument to obsview #202

Merged
merged 9 commits into from
Feb 8, 2025
Merged

add obsdim argument to obsview #202

merged 9 commits into from
Feb 8, 2025

Conversation

CarloLucibello
Copy link
Member

@CarloLucibello CarloLucibello commented Feb 8, 2025

This is a comeback of the ancient obsdim argument, in a simplified fashion.

In this new reincarnation, we don't require all functions in the library to deal with an obsdim argument, e.g. numobs and getobs have no knowledge of obsdim.

If users want to work with a non-standard (i.e. non-last) observation dimension for arrays, they wrap their data with obsview(data, obsdim) at the beginning of the pipeline, and then they forget about obsdim in the following transformations. This has been previously discussed here.

Since the slidingwindow method could be dealing often with non-standard obsdim (time), I add the argument also there. Close #199

@CarloLucibello CarloLucibello changed the title add obsdim keyword argument to obsview add obsdim argument to obsview Feb 8, 2025
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 42.85714% with 16 lines in your changes missing coverage. Please review.

Project coverage is 84.93%. Comparing base (e705227) to head (c1abdab).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
src/obsview.jl 60.00% 8 Missing ⚠️
src/slidingwindow.jl 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #202      +/-   ##
==========================================
- Coverage   86.05%   84.93%   -1.13%     
==========================================
  Files          14       15       +1     
  Lines         710      697      -13     
==========================================
- Hits          611      592      -19     
- Misses         99      105       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CarloLucibello CarloLucibello merged commit 97460d7 into main Feb 8, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

slidingwindow should have a dims keyword
2 participants