Implemented ellipse-rectangle intersection test #3833
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schillic
reviewed
Apr 17, 2025
Comment on lines
+631
to
+632
| David Eberly, “Distance Between a Point and an Ellipse, an Ellipsoid, or a Hyperellipsoid”, | ||
| Geometric Tools, 2015. https://www.geometrictools.com/Documentation/DistancePointEllipseEllipsoid.pdf |
There was a problem hiding this comment.
Where exactly can I find the algorithm in that reference?
Comment on lines
+627
to
+631
| ### Notes | ||
| It works only for 2D axis-aligned rectangles and ellipsoids. | ||
|
|
||
| ### Reference | ||
| David Eberly, “Distance Between a Point and an Ellipse, an Ellipsoid, or a Hyperellipsoid”, |
There was a problem hiding this comment.
Suggested change
| ### Notes | |
| It works only for 2D axis-aligned rectangles and ellipsoids. | |
| ### Reference | |
| David Eberly, “Distance Between a Point and an Ellipse, an Ellipsoid, or a Hyperellipsoid”, | |
| ### Notes | |
| It works only for 2D axis-aligned rectangles and ellipsoids. | |
| ### Reference | |
| David Eberly, “Distance Between a Point and an Ellipse, an Ellipsoid, or a Hyperellipsoid”, |
| @assert dim(H) == dim(E) == 2 "$H and $E must both have 2 dimensions." | ||
|
|
||
| # center to the origin | ||
| H_trans = translate(H, -H.center) |
There was a problem hiding this comment.
You do not need H_trans. You can just use H and modify the center of bbox.
Comment on lines
+643
to
+646
| bbox = overapproximate(H_trans ⊕ E_trans, Hyperrectangle) | ||
| if any(abs.(K) .> bbox.radius) | ||
| return true | ||
| end |
There was a problem hiding this comment.
Is this first part necessary? It sounds more expensive to compute than the rest of the method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a specialized
isdisjointmethod for 2dHyperrectangleandEllipsoidintersection tests(issue2064)