Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Point DotEnv to maintained fork #98762

Merged
merged 2 commits into from
Feb 19, 2024
Merged

Point DotEnv to maintained fork #98762

merged 2 commits into from
Feb 19, 2024

Conversation

tecosaur
Copy link
Contributor

DotEnv.jl is a simple but rather useful package for loading .env files.

It was started by @vmari five years ago, and has seen a few versions since. Unfortunately, it appears that in recent years Valentín has not been able to spare much time or attention for the package: the last commit was three years ago, there's an untouched PR from 2022, and the last update was quite involved (see: #32416).

I am interested in taking on this package, and growing it to fully support the canonical dotenv format (it supports a subset ATM), along with adding a few other features that I think would fit well. To that end, I opened an issue in November asking Valentín how he felt about the idea of me adopting the package: tecosaur/DotEnv.jl#15.

I have also tried to email Valentín using his git-configured email address, but got a bounce-back from that. I have not been able to find any other contact methods to reach Valentín by.

I still hope that Valentín will get back to me, but should he not within another month or so, I would think it worthwhile to update General to point to my fork, which I intend to keep maintained.

@tecosaur
Copy link
Contributor Author

tecosaur commented Feb 1, 2024

Now we've reached February, and I unfortunately still haven't heard from Valentín, I would appreciate it if the General custodians could duly consider this PR.

@DilumAluthge
Copy link
Member

@vmari

@DilumAluthge
Copy link
Member

@tecosaur I see that @vmari's GitHub profile has a link to their LinkedIn profile - can you try messaging them on LinkedIn?

@DilumAluthge
Copy link
Member

I'll also attempt to reach out to @vmari on LinkedIn.

@tecosaur
Copy link
Contributor Author

In addition to the GitHub mentions, I tried sending an email to Valentín's ubykuo.com email 12 weeks ago, and set an email to his hotmail.com email a week ago. Thanks for reaching out to him on LinkedIn too.

It's been 90 days since I first opened that issue on GitHub, so I'd advocate that should we not hear anything by the end of the month we go ahead and merge this change. How does that sound?

@DilumAluthge
Copy link
Member

Let's post in #pkg-registration and see if others have any thoughts on what the appropriate timeline should be.

@DilumAluthge
Copy link
Member

On a separate note, could we find a GitHub organization in which to put the maintained fork?

@DilumAluthge
Copy link
Member

On a separate note, could we find a GitHub organization in which to put the maintained fork?

And, to add: whatever GitHub organization we decide, we should make sure that the org has at least two organization owners.

@DilumAluthge
Copy link
Member

I messaged @vmari on LinkedIn, and I also sent an email to both of the email addresses.

@DilumAluthge
Copy link
Member

It's been 90 days since I first opened that issue on GitHub, so I'd advocate that should we not hear anything by the end of the month we go ahead and merge this change. How does that sound?

From the discussion on Slack, it sounds like people are fine with proceeding with this plan.

I would ask that we put the fork in a GitHub org (with at least two org owners), so that we reduce the chance of running into this same issue again.

@vmari
Copy link

vmari commented Feb 18, 2024

Sorry for not answering before. Let me know how I can help and who should take care of the ownership of DotEnv package. As you can see I can't take care of it as when I started.

I'll wait for instructions

@DilumAluthge
Copy link
Member

@vmari Can you transfer the DotEnv.jl repo to my GitHub username (DilumAluthge)? I'll then transfer it to the appropriate org.

Instructions for transferring a repo: https://docs.github.com/en/repositories/creating-and-managing-repositories/transferring-a-repository#transferring-a-repository-owned-by-your-personal-account

@tecosaur
Copy link
Contributor Author

I don't know what org would be appropriate. For now, I'd be happier with it just under me, as:

  • I feel pretty confident that I won't be going AWOL any time in the near future
  • I already have a half-dozen other packages under my account, so it's not like this introduces a new risk
  • Should something happen to me, I think this is likely best solved via a process here for adopting forks of abandoned packages, not me putting everything in orgs.

@tecosaur
Copy link
Contributor Author

If @vmari is happy with the proposed move here, would him giving his assent be enough to merge this PR in the same style as #56157?

@vmari
Copy link

vmari commented Feb 19, 2024

Repository is being transferred to @DilumAluthge. Feel free to move to any org/user after accepting transfer

@DilumAluthge
Copy link
Member

Thank you @vmari!

I've transferred the repo to the JuliaWeb org: https://github.com/JuliaWeb/DotEnv.jl

Next, I'll reach out to a JuliaWeb org owner to get myself and @tecosaur admin privileges on the https://github.com/JuliaWeb/DotEnv.jl repo.

@tecosaur
Copy link
Contributor Author

For clarity (and some discussion on where the Repo ends up): @vmari would you be alright if I (specifically my GH account) took over DotEnv.jl?

@vmari
Copy link

vmari commented Feb 19, 2024

@tecosaur Personally, I have no preference on where it lives as long it's actively maintained 👍

Thank you all for your patience and work trying to communicate with me and take care of Julia's ecosystem

@DilumAluthge
Copy link
Member

After a series of transfers, the original repo has now been transferred to https://github.com/tecosaur/DotEnv.jl

@@ -1,3 +1,3 @@
name = "DotEnv"
uuid = "4dc1fcf4-5e3b-5448-94ab-0c38ec0385c1"
repo = "https://github.com/vmari/DotEnv.jl.git"
repo = "https://github.com/tecosaur/DotEnv.jl.git"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original repo now lives at https://github.com/tecosaur/DotEnv.jl

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DilumAluthge DilumAluthge merged commit f787a83 into JuliaRegistries:master Feb 19, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants