Add problems 5-13 except 9,10 #375
Open
+827
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tmigot please review this pr. |
|
Hi @arnavk23 Do you need any help finishing up this one? |
tmigot
reviewed
Oct 15, 2025
tmigot
reviewed
Oct 15, 2025
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #375 +/- ##
==========================================
- Coverage 99.80% 99.80% -0.01%
==========================================
Files 1084 1105 +21
Lines 12319 12761 +442
==========================================
+ Hits 12295 12736 +441
- Misses 24 25 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@tmigot All test are passing. |
Co-authored-by: Tangi Migot <[email protected]>
Co-authored-by: Tangi Migot <[email protected]>
Co-authored-by: Tangi Migot <[email protected]>
Co-authored-by: Tangi Migot <[email protected]>
Co-authored-by: Tangi Migot <[email protected]>
Co-authored-by: Tangi Migot <[email protected]>
Co-authored-by: Tangi Migot <[email protected]>
Co-authored-by: Tangi Migot <[email protected]>
Co-authored-by: Tangi Migot <[email protected]>
Co-authored-by: Tangi Migot <[email protected]>
Co-authored-by: Tangi Migot <[email protected]>
Co-authored-by: Tangi Migot <[email protected]>
Co-authored-by: Tangi Migot <[email protected]>
Co-authored-by: Tangi Migot <[email protected]>
Co-authored-by: Tangi Migot <[email protected]>
Co-authored-by: Tangi Migot <[email protected]>
Co-authored-by: Tangi Migot <[email protected]>
Co-authored-by: Tangi Migot <[email protected]>
Co-authored-by: Tangi Migot <[email protected]>
tmigot
requested changes
Oct 26, 2025
Comment on lines
28
to
48
| function F!(r, x; n = length(x)) | ||
| s = one(T) | ||
| nb = div(n, 2) - 1 | ||
| @inbounds for i = 1:nb | ||
| i1 = 2 * i - 1 | ||
| i2 = 2 * i | ||
| i3 = 2 * i + 1 | ||
| i4 = 2 * i + 2 | ||
| s += 100 * (x[i2] - x[i1]^2)^2 | ||
| s += (one(T) - x[i1])^2 | ||
| s += 90 * (x[i4] - x[i3]^2)^2 | ||
| s += (one(T) - x[i3])^2 | ||
| s += 10 * (x[i2] + x[i4] - T(2))^2 | ||
| s += (one(T) / T(10)) * (x[i2] - x[i4])^2 | ||
| end | ||
| r[1] = sqrt(s) | ||
| @inbounds for i = 2:n | ||
| r[i] = zero(T) | ||
| end | ||
| return r | ||
| end |
There was a problem hiding this comment.
f(x) = sum(F(x)[i].^2) so we should see all the terms that are squared in the function F(x) for the NLS-variant, like you did for the others
Co-authored-by: Tangi Migot <[email protected]>
Co-authored-by: Tangi Migot <[email protected]>
Co-authored-by: Tangi Migot <[email protected]>
Co-authored-by: Tangi Migot <[email protected]>
Co-authored-by: Tangi Migot <[email protected]>
Co-authored-by: Tangi Migot <[email protected]>
Co-authored-by: Tangi Migot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#116
| Problem 5. Generalized Broyden tridiagonal function [22]. (OP)
| Problem 6. Generalized Broyden banded function [22]. (OP)
| Problem 7. Seven-diagonal generalization of the Broyden tridiagonal function [7]. (OP)
| Problem 8. Sparse modification of the Nazareth trigonometric function. (NLS)
| Problem 11. Augmented Lagrangian function [7]. (OP)
| Problem 12. Generalization of the Brown function 1 [7]. (OP)
| Problem 13. Generalization of the Brown function 2 [7]. (OP)