Skip to content

Separate sym factor #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

luke-kiernan
Copy link

Changes:

  1. Use multiple dispatch instead of @eval macros for figuring out which function to call among the real/complex and 32-bit/64-bit indexing combinations.
  2. Add a full_factor argument to klu: by passing full_factor = false, you can delay doing the numeric factorization until later. I also added nonzeros, so that there is an interface that allows for setting the nonzero values after construction.
  3. Export the functions that do symbolic/numeric factorization: klu_analyze!, klu_factor!. I also added klu_refactor! as an alias for klu!, for naming consistency with the SuiteSparse functions.

I couldn't easily figure out documentation/formatting stuff, so I did my best to match what you have there.

Copy link

codecov bot commented May 27, 2025

Codecov Report

Attention: Patch coverage is 66.36364% with 37 lines in your changes missing coverage. Please review.

Project coverage is 56.27%. Comparing base (7479676) to head (e9996f2).

Files with missing lines Patch % Lines
src/KLU.jl 68.05% 23 Missing ⚠️
src/type_resolution.jl 63.15% 14 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #28      +/-   ##
==========================================
+ Coverage   55.24%   56.27%   +1.02%     
==========================================
  Files           2        3       +1     
  Lines         572      606      +34     
==========================================
+ Hits          316      341      +25     
- Misses        256      265       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant