Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backtrack on non-finite deviance values #577

Merged
merged 2 commits into from
Nov 21, 2024
Merged

Conversation

andreasnoack
Copy link
Member

The current criterion for backtracking assumes that the deviance computed is finite. Hence, extreme parameter values can cause termination instead of reduction of the step.

Fixes #417

The current criterion for backtracking assumes that the deviance
computed is finite. Hence, extreme parameter values can cause
termination instead of reduction of the step.
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.33%. Comparing base (f6f4f70) to head (9e1729c).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #577      +/-   ##
==========================================
+ Coverage   89.95%   90.33%   +0.37%     
==========================================
  Files           8        8              
  Lines        1105     1107       +2     
==========================================
+ Hits          994     1000       +6     
+ Misses        111      107       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

src/glmfit.jl Show resolved Hide resolved
test/runtests.jl Outdated Show resolved Hide resolved
Co-authored-by: David Widmann <[email protected]>
@andreasnoack andreasnoack merged commit 89493a4 into master Nov 21, 2024
13 checks passed
@andreasnoack andreasnoack deleted the an/safebacktracking branch November 21, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deviance NaN from first iteration onwards with Gamma distributed GLM with LogLink
2 participants