fix(deps): include e2b in full extra - #1
Closed
dannyward630 wants to merge 1 commit into
Closed
Conversation
2 tasks
Author
|
Closing this follow-up because it is now obsolete. Its patch is byte-equivalent to I also verified the current SWE-agent#792 head:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is a small follow-up for SWE-agent#792.
The upstream pylint workflow installs
.[full]and then lints the wholeminisweagent/package. The E2B environment importse2blazily, but pylint still resolves those imports while checking the new module. Adding thee2bextra tofullmakes the workflow install the optional SDK before linting the E2B backend.Validation
.venv/bin/python -m pip install -e '.[e2b]'.venv/bin/pylint src/minisweagent/environments/extra/e2b.py --errors-only.venv/bin/python -m pytest tests/environments/extra/test_e2b.py.venv/bin/ruff check pyproject.toml src/minisweagent/environments/extra/e2b.py tests/environments/extra/test_e2b.pygit diff --check