Skip to content

fix(deps): include e2b in full extra - #1

Closed
dannyward630 wants to merge 1 commit into
JunYeopLee:feat/e2b-environmentfrom
dannyward630:codex/e2b-full-extra
Closed

fix(deps): include e2b in full extra#1
dannyward630 wants to merge 1 commit into
JunYeopLee:feat/e2b-environmentfrom
dannyward630:codex/e2b-full-extra

Conversation

@dannyward630

Copy link
Copy Markdown

Summary

This is a small follow-up for SWE-agent#792.

The upstream pylint workflow installs .[full] and then lints the whole minisweagent/ package. The E2B environment imports e2b lazily, but pylint still resolves those imports while checking the new module. Adding the e2b extra to full makes the workflow install the optional SDK before linting the E2B backend.

Validation

  • .venv/bin/python -m pip install -e '.[e2b]'
  • .venv/bin/pylint src/minisweagent/environments/extra/e2b.py --errors-only
  • .venv/bin/python -m pytest tests/environments/extra/test_e2b.py
  • .venv/bin/ruff check pyproject.toml src/minisweagent/environments/extra/e2b.py tests/environments/extra/test_e2b.py
  • git diff --check

@dannyward630

Copy link
Copy Markdown
Author

Closing this follow-up because it is now obsolete. Its patch is byte-equivalent to 21d7e63d, which is already present on SWE-agent#792, and the current upstream PR head includes mini-swe-agent[e2b] in the full extra.

I also verified the current SWE-agent#792 head:

  • focused E2B and SWE-bench tests — 50 passed, 8 skipped
  • Ruff on the affected modules/tests — passed
  • git diff --check — passed

@dannyward630
dannyward630 deleted the codex/e2b-full-extra branch June 29, 2026 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant