test(gateway): cover profile startup on a fresh database - #8
Open
cnYui wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ProfileManageragainst a freshly initialized gateway databasefinallyso the refresh interval cannot leakWhy
The missing
agent_profilestable reported in #2 was fixed directly onmain, but the existing store tests initialize their own schema and do not exercise the gateway's main database initializer. This test locks the runtime startup contract without coupling to the SQL DDL text.Related to #2. The production fix is already on
main, so this PR intentionally does not close the issue.Testing
npm test -- --runInBand api-smoke- 1 suite, 5 tests passednpm run build- passednpm test -- --runInBand- 97 suites, 1242 tests passedgit diff --check- passedAll verification used Node.js 20.20.2, matching the repository's supported runtime line.