Skip to content

Add workaround #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ogoffart merged 2 commits into from
Feb 25, 2020
Merged

Add workaround #86

ogoffart merged 2 commits into from
Feb 25, 2020

Conversation

@driverCzn
Copy link
Contributor

@driverCzn driverCzn commented Feb 25, 2020

Add some notes from #74 .

@driverCzn
Add workaround
3976604 
Add some notes from KDAB#74 .
@claassistantio
Copy link

claassistantio commented Feb 25, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ogoffart
Copy link
Contributor

ogoffart commented Feb 25, 2020

Thanks for your contribution!
These instructions are however very specific to a particular version of ubuntu.
Maybe the text could be different. Instead of a comment in the code, add what to type for ubuntu in the text before when it mentions the dependencies

@driverCzn
Add workaround
1020b6c 
Add some tips for Ubuntu with llvm-6 and clang-6.
@ogoffart ogoffart merged commit 5b22b6a into KDAB:master Feb 25, 2020
@ogoffart
Copy link
Contributor

ogoffart commented Feb 25, 2020

Thanks!

@driverCzn
Copy link
Contributor Author

driverCzn commented Feb 25, 2020

Thanks for your suggestion!
And I modify the text to make the tip more noticeable.

@driverCzn driverCzn deleted the patch-1 branch February 25, 2020 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@driverCzn @claassistantio @ogoffart