Add qobject extension trait #1226

BenFordTytherington · 2025-03-14T11:56:17Z

cxx-qt-lib trait for additional qobject wrappers

Closes #562

The added methods are:

blockSignals
signalsBlocked
setObjectName
objectName
parent
setParent

crates/cxx-qt-lib/src/core/mod.rs

codecov · 2025-03-14T12:07:03Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (64d4ee6) to head (0fc5b11).

Additional details and impacted files

@@            Coverage Diff            @@
##              main     #1226   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           73        73           
  Lines        12612     12612           
=========================================
  Hits         12612     12612

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

crates/cxx-qt-lib/src/core/qobject.rs

LeonMatthesKDAB

Some nitpicks, and some documentation is missing.

Otherwise looks good :)

LeonMatthesKDAB · 2025-03-31T09:51:42Z

crates/cxx-qt-lib/src/core/qobject.rs

+//
+// SPDX-License-Identifier: MIT OR Apache-2.0
+
+use cxx_qt::QObject;


Please make this a pub use and add a cxx-qt-lib/qobject.h header that just includes the header from Qt.

This way we the import follows the usual pattern:

extern "C++" { include("cxx-qt-lib/qobject.h"); type QObject = cxx_qt_lib::QObject; }

This breaks an orphan rule, so I think it needs to just be the type def, which is what happens inside the cxx bridge in cxx_qt::QObject.

LeonMatthesKDAB · 2025-03-31T09:53:14Z

crates/cxx-qt-lib/src/core/qobject.rs

+        pub fn parent(self: &QObjectExternal) -> *mut QObjectExternal;
+
+        #[rust_name = "set_parent"]
+        pub unsafe fn setParent(self: Pin<&mut QObjectExternal>, parent: *mut QObjectExternal);


You should be able to use parent: *mut QObject here and re-import the QObject from cxx_qt.

LeonMatthesKDAB · 2025-03-31T10:00:34Z

crates/cxx-qt-lib/src/core/qobject.rs

+        type QString = crate::QString;
+
+        #[rust_name = "block_signals"]
+        pub fn blockSignals(self: Pin<&mut QObjectExternal>, block: bool) -> bool;


Nit: You can use the shorthand syntax self: Pin<&mut Self>/&self here if you move the QString import into a separate extern "C++" block.

Also a good reminder that we don't support this in CXX-Qt yet...
I've opened an issue for it: #1245

Can fix once #1249 gets merged

crates/cxx-qt-lib/src/core/qobject.rs

- cxx-qt-lib trait for additional qobject wrappers - adds blockSignals - adds signalsBlocked - adds setObjectName - adds objectName - adds parent - adds setParent