qt-build-utils: build system changes to have a QtInstallation #1230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1230 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 73 73
Lines 12681 12681
=========================================
Hits 12681 12681 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ahayzen-kdab
force-pushed
the
1125-build-system-changes-qtinstallation
branch
from
5f33455 to
8dcd7d5
Compare
ahayzen-kdab
force-pushed
the
1125-build-system-changes-qtinstallation
branch
6 times, most recently
from
634fb0d to
1ad252a
Compare
ahayzen-kdab
force-pushed
the
1125-build-system-changes-qtinstallation
branch
from
fefe5fc to
155f7a1
Compare
ahayzen-kdab
commented
Apr 23, 2025
ahayzen-kdab
commented
Apr 23, 2025
ahayzen-kdab
force-pushed
the
1125-build-system-changes-qtinstallation
branch
from
155f7a1 to
86a7f22
Compare
ahayzen-kdab
commented
Apr 24, 2025
ahayzen-kdab
force-pushed
the
1125-build-system-changes-qtinstallation
branch
2 times, most recently
from
328cc00 to
01dc659
Compare
ahayzen-kdab
commented
May 1, 2025
ahayzen-kdab
commented
May 1, 2025
ahayzen-kdab
commented
May 1, 2025
ahayzen-kdab
force-pushed
the
1125-build-system-changes-qtinstallation
branch
2 times, most recently
from
cdb31a3 to
7015b0f
Compare
| // } | ||
| fn link_modules(&self, builder: &mut cc::Build, qt_modules: &[String]); | ||
| /// Find the path to a given Qt tool for the Qt installation | ||
| fn try_find_tool(&self, tool: QtTool) -> Option<PathBuf>; |
There was a problem hiding this comment.
This should probably return an anyhow::Result instead of an Option.
Otherwise it can be heard to decipher why a required tool could not be found.
crates/qt-build-utils/src/lib.rs
Outdated
| /// rather than `"QtCore"`). | ||
| // | ||
| // TODO: is there a better name for this method or a sane way to create a default QtInstallation? | ||
| pub fn new_with_default_installation(qt_modules: Vec<String>) -> anyhow::Result<Self> { |
There was a problem hiding this comment.
This should be new and the other one should be with_installation as "automatically doing the right thing" should be the behavior of new.
LeonMatthesKDAB
force-pushed
the
1125-build-system-changes-qtinstallation
branch
from
b0f57b4 to
6c94838
Compare
|
I somehow managed to close this PR with an ill-formed force-push 🤯 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of one of the steps towards #1125 and rewriting qt-build-utils.