Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create generate.sh scripts for QHash and QMap #1244

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

jnbooth
Copy link
Contributor

@jnbooth jnbooth commented Mar 29, 2025

Like cxx-qt-lib/src/core/qlist/generate.sh, but for QHash and QMap.

Copy link

codecov bot commented Mar 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (626371a) to head (c99c82c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1244   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           73        73           
  Lines        12612     12612           
=========================================
  Hits         12612     12612           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@LeonMatthesKDAB LeonMatthesKDAB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jnbooth Thank you for your contributions :)

Please add the generated files to .gitattributes so that they show up as generated in future PRs.

This also seems a bit overkill for qmap, as that only has a single variant at the moment, but will probably come in handy at some point.

@jnbooth
Copy link
Contributor Author

jnbooth commented Apr 1, 2025

@LeonMatthesKDAB Oh, right. Okay, I added them to .gitattributes.

@jnbooth jnbooth requested a review from LeonMatthesKDAB April 1, 2025 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants