Fix: Constructors no longer fail silently #1295
Open
+43
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1295 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 75 75
Lines 13051 13077 +26
=========================================
+ Hits 13051 13077 +26 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
BenFordTytherington
force-pushed
the
missing-constructor-error
branch
3 times, most recently
from
a9f26a3 to
080cb5f
Compare
BenFordTytherington
force-pushed
the
missing-constructor-error
branch
2 times, most recently
from
18a487e to
6547d3d
Compare
ahayzen-kdab
reviewed
Oct 3, 2025
BenFordTytherington
force-pushed
the
missing-constructor-error
branch
3 times, most recently
from
683889c to
c016271
Compare
- A shim trait is used to check whether the user declared a constructor - This is implemented by the bridge if you add the constructor trait in bridge - This will then allow you to implemented constructor for your type - This prevents constructors not being used silently
- Add lifetime - Update span
BenFordTytherington
force-pushed
the
missing-constructor-error
branch
from
c016271 to
101ca81
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
impl Constructor<()> for ... {}in the bridge silently fails #1233