-
-
Notifications
You must be signed in to change notification settings - Fork 0
chore: clarify repository split - remove production/SaaS references #47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- Remove production/SaaS references from KIIAREN-Release - Update README to clarify this is self-hosted edition only - Remove notable-mouse production deployment references - Add REPOSITORY-SPLIT.md documentation - Update Convex setup docs to use generic deployment names - Update saas remote to point to fentz26/KIIAREN-SAAS KIIAREN-Release is now clearly for self-hosted deployments only. Production SaaS deployment (kiiaren.com) uses KIIAREN-SAAS repository.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (5)
Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR establishes a clear separation between the self-hosted open-source repository (KIIAREN-Release) and the private production SaaS repository (KIIAREN-SAAS). It removes production-specific code and references, ensuring this repository focuses solely on self-hosted deployments.
Changes:
- Removed production deployment checks and SaaS-specific logic from authentication configuration
- Updated documentation to use generic deployment names instead of hardcoded production values
- Added comprehensive repository split documentation explaining the differences between editions
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| convex/auth.ts | Removed production deployment detection and SITE_URL override logic, replaced with clarifying comments |
| docs/setup/convex.md | Replaced hardcoded production deployment references with generic placeholders for self-hosted users |
| REPOSITORY-SPLIT.md | Added new documentation file explaining the repository split, deployment models, and contribution guidelines |
| README.md | Updated title and introduction to clarify this is the self-hosted edition, added note about SaaS repository |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 issue found across 4 files
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="REPOSITORY-SPLIT.md">
<violation number="1" location="REPOSITORY-SPLIT.md:48">
P2: Consider using a placeholder instead of what appears to be a real production Convex deployment identifier (`prod:notable-mouse-667`). Exposing actual production infrastructure names in public documentation is generally discouraged for security reasons. Use something like `prod:your-deployment-name` or `prod:<deployment-id>` instead.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
| - `SITE_URL` - User's own deployment URL | ||
|
|
||
| ### KIIAREN-SAAS (Production) | ||
| - `CONVEX_DEPLOYMENT` - Production deployment (`prod:notable-mouse-667`) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P2: Consider using a placeholder instead of what appears to be a real production Convex deployment identifier (prod:notable-mouse-667). Exposing actual production infrastructure names in public documentation is generally discouraged for security reasons. Use something like prod:your-deployment-name or prod:<deployment-id> instead.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At REPOSITORY-SPLIT.md, line 48:
<comment>Consider using a placeholder instead of what appears to be a real production Convex deployment identifier (`prod:notable-mouse-667`). Exposing actual production infrastructure names in public documentation is generally discouraged for security reasons. Use something like `prod:your-deployment-name` or `prod:<deployment-id>` instead.</comment>
<file context>
@@ -0,0 +1,77 @@
+- `SITE_URL` - User's own deployment URL
+
+### KIIAREN-SAAS (Production)
+- `CONVEX_DEPLOYMENT` - Production deployment (`prod:notable-mouse-667`)
+- `NEXT_PUBLIC_CONVEX_URL` - Production Convex URL
+- `SITE_URL` - `https://auth.kiiaren.com` (production)
</file context>
| - `CONVEX_DEPLOYMENT` - Production deployment (`prod:notable-mouse-667`) | |
| - `CONVEX_DEPLOYMENT` - Production deployment (e.g., `prod:<your-deployment-id>`) |
|
|
||
| - **KIIAREN-Release** should NOT be connected to Vercel | ||
| - **KIIAREN-SAAS** is the only repository that should deploy to Vercel | ||
| - Production domains should only point to KIIAREN-SAAS deployments No newline at end of file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Production infrastructure details committed to open-source repository
Medium Severity
The newly added VERCEL-SETUP.md file contains production infrastructure details including Vercel project ID (prj_06oPzPlQO3zb4eZo0cMxbzqWeNnJ), team ID, production deployment name (prod:notable-mouse-667), and production domains (kiiaren.com, auth.kiiaren.com). This directly contradicts REPOSITORY-SPLIT.md which states KIIAREN-Release has "❌ No references to kiiaren.com production URLs" and "❌ No Vercel deployment configuration". This file appears to be internal team documentation that was accidentally included in the open-source repository.
Summary
Clarifies the split between KIIAREN-Release (self-hosted) and KIIAREN-SAAS (production SaaS).
Changes
Impact
Note
Scope: Formalizes repo split and removes SaaS-specific code/links from the self-hosted edition.
README.mdtoKIIAREN-Release(self-hosted only) with updated badge and deployment notesREPOSITORY-SPLIT.mddetailing responsibilities, env vars, and code differences betweenKIIAREN-ReleaseandKIIAREN-SAASVERCEL-SETUP.mdinstructing Vercel to connect tofentz26/KIIAREN-SAAS(not this repo)convex/auth.ts: remove production deployment checks and hardcoded domains; self-host onlydocs/setup/convex.md: replace production-specific IDs/URLs with generic placeholders and steps for user deploymentsWritten by Cursor Bugbot for commit c8e65f9. This will update automatically on new commits. Configure here.