Feat/final documentation#4
Conversation
…r various CRM features.
…various CRM modules and features.
…oss various modules.
…h for settings and frontend click handling.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0e3981862c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| JOIN `tabCRM Customer` referrer ON ( | ||
| referrer.referral_code = l.referral_through | ||
| OR JSON_CONTAINS(referrer.accounts, JSON_OBJECT('client_id', l.referral_through)) | ||
| ) |
There was a problem hiding this comment.
Changing this join to an inner JOIN drops every lead whose referral_through value does not resolve to a CRM Customer, so referral metrics are now undercounted whenever there are historic/unknown/default codes. This also makes the fallback COALESCE(..., CONCAT('Referrer (...)')) path ineffective, and the same regression appears again in get_referral_source_table with the corresponding join.
Useful? React with 👍 / 👎.
| <div v-else-if="customersList.data" class="flex h-full items-center justify-center"> | ||
| <div class="flex flex-col items-center gap-3 text-xl font-medium text-ink-gray-4"> | ||
| <span>No Customers Found</span> | ||
| <Button v-if="canWriteCustomers" :label="'New Customer'" @click="showCreateDialog = true"> | ||
| <template #prefix><FeatherIcon name="plus" class="h-4" /></template> | ||
| </Button> | ||
| </div> |
There was a problem hiding this comment.
The Customers page no longer exposes any "New Customer" action in the list/empty-state UI, while the create dialog and submit logic remain in the script, leaving write-enabled users without a way to create customers from this screen. This is a workflow regression for teams that onboard customers from /customers.
Useful? React with 👍 / 👎.
1 participant
No description provided.