Skip to content

strm2oas lef/def/gds collect drops cells referenced by sky130 spare #2014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
stefanottili opened this issue Apr 2, 2025 · 3 comments · Fixed by #2017
Closed

strm2oas lef/def/gds collect drops cells referenced by sky130 spare #2014

stefanottili opened this issue Apr 2, 2025 · 3 comments · Fixed by #2017
Assignees
@klayoutmatthias
Labels
bug
Milestone
0.30.1

Comments

@stefanottili
Copy link

stefanottili commented Apr 2, 2025 •
edited
Loading

Test-case sent by mail.
@stefanottili
Copy link
Author

It seems my mail got stuck in my outbox, so here's the tarfile of the test-case.
test_strm2oas.tgz

klayoutmatthias pushed a commit that referenced this issue Apr 5, 2025
Fixed issue #2014 (strm2oas lef/def/gds collect drops cells reference…
bcf14ed 
…d by sky130 spare)

Problem was that there was the implicit assumption that
substitution cells would be top cells (or at least: not
child cells of other substitution cells).
@klayoutmatthias
Copy link
Collaborator

I had not considered that case that a COMPONENT replacement cell would use other COMPONENT replacements as child cells. This is a more basic issue of the "create_multi_mapping" function.

@klayoutmatthias klayoutmatthias linked a pull request Apr 5, 2025 that will close this issue
Fixed issue #2014 (strm2oas lef/def/gds collect drops cells reference… #2017
Merged
@klayoutmatthias
Copy link
Collaborator

I see your other point regarding the XOR results: one shape appears in the XOR output on layer 236/0 which is a false positive. That is a bug in the optimization we introduced: A cell is skipped when entirely covered by a box. That needs variant building as in one cell this is the case while in the other it isn't.

I will try to include a fix in this ticket too.

Matthias

@klayoutmatthias klayoutmatthias self-assigned this Apr 26, 2025
@klayoutmatthias klayoutmatthias added this to the 0.30.1 milestone Apr 26, 2025
klayoutmatthias added a commit that referenced this issue Apr 27, 2025
@klayoutmatthias
Merge pull request #2017 from KLayout/bugfix/issue-2014
e76e9b7 
Fixed issue #2014 (strm2oas lef/def/gds collect drops cells reference…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@klayoutmatthias klayoutmatthias

Labels
bug
Projects
None yet
Milestone
0.30.1
Development

Successfully merging a pull request may close this issue.

Fixed issue #2014 (strm2oas lef/def/gds collect drops cells reference… KLayout/klayout
2 participants
@klayoutmatthias @stefanottili