Move chemical plant to long-term life support, and some other minor stuff #2483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wrong branch lol
|
also fix some typos in comments (ignore the tech tree commits, that was the wrong branch) |
|
Copy KSP-RO/ROSolar#22 as well |
Clayell
changed the title
Clayell
added a commit
to Clayell/RP-1
that referenced
this pull request
Feb 6, 2025
(should be done with KSP-RO#2483)
Clayell
added a commit
to Clayell/RP-1
that referenced
this pull request
Feb 6, 2025
(should be done with KSP-RO#2483)
Clayell
added a commit
to Clayell/RP-1
that referenced
this pull request
Feb 6, 2025
(should be done with KSP-RO#2483)
Clayell
added a commit
to Clayell/RP-1
that referenced
this pull request
Feb 6, 2025
(should be done with KSP-RO#2483)
Clayell
added a commit
to Clayell/RP-1
that referenced
this pull request
Feb 6, 2025
(should be done with KSP-RO#2483)
Clayell
added a commit
to Clayell/RP-1
that referenced
this pull request
Feb 6, 2025
(should be done with KSP-RO#2483)
Clayell
added a commit
to Clayell/RP-1
that referenced
this pull request
Feb 6, 2025
(should be done with KSP-RO#2483)
|
There's a lot of changes here that look like they shouldn't be here |
|
These are some generic typos and such, are any of these commits problematic to you? I didn't want to make 10 PR's for minor changes. |
|
I'm not merging this out of principle |
|
Ok, fine. |
This was referenced Feb 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The chemical plant has no processes available until this tech anyway, so having it present decades early only serves to confuse people with the similar-looking ECLSS.
Reported by ezsnack (https://discord.com/channels/319857228905447436/620690446540341261/1329520956628140103)