Merged
Conversation
munwalk
approved these changes
Dec 1, 2025
munwalk
left a comment
There was a problem hiding this comment.
9주차 과제 수고많으셨습니다!
OAuth 2.0, JWT, Bearer Token 키워드를 명확하게 정리하셨고, JWT 생성/검증 로직을 완벽하게 구현하셨네요! 하드코딩된 :userId를 제거하고 req.user.id를 사용하도록 수정하셨고, 내 정보 수정 API도 잘 구현하셨습니다. API 모두에 isLogin 미들웨어를 적용하고, Swagger에 BearerAuth 보안 설정까지 추가하신 점이 훌륭합니다~
수고하셨습니다!
10주차 과제 수고하셨습니다!
CI/CD, GitHub Actions, Reverse Proxy, HTTPS 키워드를 잘 정리하셨네요! GitHub Actions 워크플로우 파일의 기본 구조도 작성하셨고, main 브랜치 push와 수동 실행 설정도 완료하셨습니다.
다만, 실제 배포를 실행하는 steps: 부분이 TODO로 남아있어서 배포가 완료되지 않았습니다.
조금만 더 힘내서 완성해보세요~ 수고하셨습니다!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✅ 9, 10주차 워크북 완료 🎉
워크북을 완료한 챌린저분들, 수고 많으셨습니다!
이곳에 학습 진행 중 트러블슈팅(문제 해결 경험), 커밋별 설명, 그리고 소감을 자유롭게 남겨주세요.
서로의 경험을 공유하며 성장해봐요! 🚀
🛠️ 트러블슈팅 (Troubleshooting)
문제
원인 분석
해결 방법
📌 커밋별 설명 (Commit Log)