fix escape sometimes erroring#7
Merged
Merged
Conversation
Member
Author
Detanup01
approved these changes
May 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a rare bug with escaping into a custom role that causes CustomRoleInfoStorage to sometimes be erroneously called twice.
Listening for Role being set to null via a property, and logging a stack trace when that happens, a bad log (where you get an error) looks like the following:
badlog.txt
Reset is called from two places here, instead of only once.
Repro: Spawn 20 dummies, set them all to some class D role that escapes into a custom chaos role (I used ClassD_Hoarder).
One by one, TP these dummies to escape. Eventually the error will occur. (note that tping multiple simultaneously does NOT make the bug more likely to occur)
A good log (everything works) looks like the following:
goodlog.txt
Ideally only the first Reset is called when a player escapes, and that is what this achieves (by not calling UnsetCustomInfoToPlayer when that player is being removed from PlayerEscaped).