Skip to content

fix(tests): make kernels_pull path assertions work on Windows - #1149

Merged
stevemessick merged 1 commit into
Kaggle:mainfrom
sridipbasu:fix/kernels-pull-windows-paths
Jul 24, 2026
Merged

fix(tests): make kernels_pull path assertions work on Windows#1149
stevemessick merged 1 commit into
Kaggle:mainfrom
sridipbasu:fix/kernels-pull-windows-paths

Conversation

@sridipbasu

Copy link
Copy Markdown
Contributor

Summary

This PR fixes three Windows-only test failures in tests/unit/test_kernels_pull.py.

Problem

The tests were using POSIX-style paths in the mocked values, while the production code builds paths using os.path.join(). This caused the path assertions to fail on Windows even though the production code was working correctly.

Fix

Normalize the mocked base paths so the expected paths match how the production code builds them on each platform.

This is a test-only change and does not modify any production code.

Testing

  • Verified the three previously failing tests now pass on Windows.
  • Ran the full unit test suite to make sure no other tests were affected.

@sridipbasu

Copy link
Copy Markdown
Contributor Author

@stevemessick
Hey, I went ahead and worked on the Windows test failures as well. I opened a separate PR as you requested!

It's a test-only change that makes the test_kernels_pull.py path assertions OS-agnostic without changing any production code. I'd really appreciate it if you could take a look whenever you have time. Thanks!

@sridipbasu

Copy link
Copy Markdown
Contributor Author

Also, just wanted to say thanks for all the reviews and guidance over the past week. I've been working on quite a few fixes recently, so I definitely appreciate you taking the time to point things out and explain them. It's been really helpful, and I've learned a lot from your feedback. Thanks again!

@stevemessick

Copy link
Copy Markdown
Contributor

/gcbrun

@stevemessick stevemessick left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@stevemessick
stevemessick merged commit 6c558e7 into Kaggle:main Jul 24, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants