fix(tests): make kernels_pull path assertions work on Windows - #1149
Merged
stevemessick merged 1 commit intoJul 24, 2026
Merged
Conversation
Contributor
Author
|
@stevemessick It's a test-only change that makes the |
Contributor
Author
|
Also, just wanted to say thanks for all the reviews and guidance over the past week. I've been working on quite a few fixes recently, so I definitely appreciate you taking the time to point things out and explain them. It's been really helpful, and I've learned a lot from your feedback. Thanks again! |
Contributor
|
/gcbrun |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes three Windows-only test failures in
tests/unit/test_kernels_pull.py.Problem
The tests were using POSIX-style paths in the mocked values, while the production code builds paths using
os.path.join(). This caused the path assertions to fail on Windows even though the production code was working correctly.Fix
Normalize the mocked base paths so the expected paths match how the production code builds them on each platform.
This is a test-only change and does not modify any production code.
Testing