Skip to content

fix(tests): make kernels_pull path assertions work on Windows #1149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stevemessick merged 1 commit into from
Jul 24, 2026
Merged

fix(tests): make kernels_pull path assertions work on Windows #1149

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions tests/unit/test_kernels_pull.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,7 +245,10 @@ def exists_side_effect(p):
m = mock_open(read_data=metadata_json)
mock_open_file.side_effect = m

self.api.kernels_pull(None, path="/tmp/dummy")
# Pass the OS-native effective path so os.path.join() in production yields
# separators that match the os.path.normpath() expectations below (on
# Windows a POSIX-style path would keep forward slashes and not match).
self.api.kernels_pull(None, path=effective_path)

mock_open_file.assert_any_call(metadata_path)

Expand All @@ -268,7 +271,9 @@ def test_kernels_pull_no_kernel_metadata_placeholder(self, mock_open_file, mock_
self.api.kernels_pull(None, path="/tmp/dummy")
self.assertIn("A kernel must be specified", str(context.exception))

@patch("os.getcwd", return_value="/tmp/cwd")
# os.path.normpath keeps the mocked cwd OS-native so production's os.path.join()
# matches the os.path.normpath() expectations below on Windows and Linux alike.
@patch("os.getcwd", return_value=os.path.normpath("/tmp/cwd"))
@patch("os.path.exists")
@patch("os.path.isfile")
@patch("builtins.open")
Expand Down Expand Up @@ -316,7 +321,9 @@ def exists_side_effect(p):
@patch("os.path.exists", return_value=True)
@patch("os.path.isfile", return_value=False)
@patch("builtins.open", new_callable=mock_open)
@patch.object(KaggleApi, "get_default_download_dir", return_value="/tmp/default_dir")
# os.path.normpath keeps the mocked download dir OS-native so production's
# os.path.join() matches the os.path.normpath() expectation below on Windows.
@patch.object(KaggleApi, "get_default_download_dir", return_value=os.path.normpath("/tmp/default_dir"))
@patch.object(KaggleApi, "build_kaggle_client")
def test_kernels_pull_no_path(self, mock_client, mock_get_dir, mock_open_file, mock_isfile, mock_exists):
mock_kaggle = MagicMock()
Expand Down
Loading