fix(i18n): audit English source copy and fallback coverage - #79
Open
paulinaapeh8 wants to merge 1 commit into
Open
fix(i18n): audit English source copy and fallback coverage#79paulinaapeh8 wants to merge 1 commit into
paulinaapeh8 wants to merge 1 commit into
Conversation
…1#69) - EN locale: add 6 missing wallet_setup keys that were present in ES (install_freighter_alt, install_freighter_link, error_popup_blocked, error_wallet_locked, error_no_network, error_generic) - EN locale: improve home.wallet_disconnected_description to match the informativeness of the ES version (mentions Freighter + reconnect button) - EN locale: improve wallet_setup.freighter_not_detected_description to clarify Albedo requires no installation - ES locale: fix not_found.message and not_found.return_home — were accidentally left in English - ES locale: fix missing accent marks in profile section: mint_button_max_tier ('maximo' → 'máximo'), toast_minted_title ('exito' → 'éxito'), toast_error_connection_title ('Conexion' → 'Conexión'), mint_feedback.insufficient_level_title ('Aun' → 'Aún'), mint_feedback.already_minted_description ('reputacion' → 'reputación'), mint_feedback.generic_description ('Intentalo' → 'Inténtalo') - i18n/config.ts: expand comment to document the 3-step fallback chain (en → es → key path) so the behavior is clear to future contributors - PR_TEST_CHECKLIST.md: add section 9 with i18n/locale test cases covering both EN and ES string rendering and fallback verification Closes Kalebtron1#69
|
@paulinaapeh8 is attempting to deploy a commit to the alankcr1-6443's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@paulinaapeh8 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #69
What changed
EN locale (
src/i18n/locales/en.ts)wallet_setupkeys that existed in ES but not EN:install_freighter_alt,install_freighter_link,error_popup_blocked,error_wallet_locked,error_no_network,error_generic. Without these, the fallback chain would have returned Spanish strings in English mode.home.wallet_disconnected_description: was "Freighter is not available. Reconnect your wallet to operate." — now matches the ES version's detail: "Your wallet is not available. Make sure Freighter is installed and unlocked, or use the reconnect button."wallet_setup.freighter_not_detected_description: clarified that Albedo requires no installation (was truncated with "...")ES locale (
src/i18n/locales/es.ts)not_found.messageandnot_found.return_home: these were accidentally left in English ("Oops! Page not found", "Return to Home") — corrected to "¡Ups! Página no encontrada" and "Volver al inicio"profilesection:mint_button_max_tier:maximo→máximotoast_minted_title:exito→éxitotoast_error_connection_title:Conexion→Conexiónmint_feedback.insufficient_level_title:Aun→Aúnmint_feedback.already_minted_description:reputacion→reputaciónmint_feedback.generic_description:Intentalo→Inténtaloi18n config (
src/i18n/config.ts)PR_TEST_CHECKLIST.md
Before / after
en: wallet_setup.error_popup_blockeden: home.wallet_disconnected_descriptiones: not_found.messagees: profile.mint_button_max_tieres: profile.toast_minted_titlees: profile.toast_error_connection_titleFallback behavior
Missing key path: EN → ES (
fallbackLng) → raw key string (parseMissingKeyHandler). This is unchanged — the PR improves coverage so fewer keys reach the fallback. TheparseMissingKeyHandleris intentionally left returning the key path so gaps remain visible during review.Validation
npm run buildexits 0 with no TypeScript or compilation errors.