Systray icon white on dark mode and macOS #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. I'll fix it in RabbitCommon. |
KangLin
added a commit
to KangLin/RabbitCommon
that referenced
this pull request
Aug 30, 2025
KangLin
added
invalid
KangLin
force-pushed
the
master
branch
8 times, most recently
from
1a0f8a2 to
ff2e599
Compare
KangLin
force-pushed
the
master
branch
6 times, most recently
from
0822b5c to
1e11faa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows (with Dark mode theme enabled) and macOS (which always have a dark tray), it's almost impossible to find Rabbit Remote Control icon on the systray because it matches the color of the systray. This PR is a proof of concept that I do believe you can develop it further and make it better to (1) always use white app systray icon on macOS in "rabbit-black" theme or (2) if the system is running in Dark mode (e.g. Windows) and "rabbit-black" is the default theme, uses a white app systray icon instead.
I tried to temporarily replace the theme by using
QIcon::setThemeName("rabbit-white"), but it doesn't work, so I had to copy theapp.svgfile fromrabbit-whiteover torabbit-blackand rename it to "app-invert", but maybe there's a better way to do this.Also, maybe it would be better to copy the function to detect dark-mode to RabbitCommon instead, but I don't know how to declare headers to add a function, and not sure if I can load a function from there on Rabbit Remote Control MainWindow, as I wasn't able to read the
QIcon::themeNamewhich should be set from there to detect ifrabbit-blackwas in use, so I read the Rabbit Remote Control conf file directly.