Conversation
Add json serialization/deserialization for the duration field
litvitnik
reviewed
Oct 23, 2025
| @Size(max = 200, message = "The film description must not exceed 200 characters") | ||
| private String description; | ||
|
|
||
| private LocalDate releaseDate; |
There was a problem hiding this comment.
Лучше создать свою собственную аннотацию для условия, что дата релиза должна быть не раньше 28 декабря 1895 года. Если не получится, то ничего страшного приму так, если получится, то будет супер)
Add NotBeforeCinemaBirthday and NotBeforeCinemaBirthdayValidator and use it for Film.releaseDate validation
Fix id generating
Delete unused imports
Fix createFilm_shouldAssignIdAndStoreFilm test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.