Merged
Conversation
FilmStorage.addFilm and FilmStorage.updateFilm returns Film object
UserStorage.addUser and UserStorage.updateUser returns User object
Add scope prototype annotation
Add FilmStorage.getTopNFilmsByLikes and InMemoryFilmStorage.getTopNFilmsByLikes
Use UserService
Add UserService.deleteUserById
Add UserController.deleteUser
Remove the suffix "Film" from methods
Remove the suffix "User" from methods
Remove the suffix "User" from methods
Remove the suffix "Film" from methods
Delegate to UserService.deleteById
Delete the suffix "User" from methods
Use FilmService
Use FriendshipViolationException
Use PositiveDuration instead of setter validation
Use MethodArgumentNotValidException instead of ValidationException
Delete method FilmService.getTopTenFilmsByLikes Add method FilmService.getTopNFilmsByLikes
Rename Film.likeFrom to Film.likeBy Rename Film.unlikeFrom to Film.unlikeBy
Add FilmService.like, FilmService.unlike
Add FilmController.like endpoint
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.