Open
Conversation
Add Film.rating, Film.genres
Separate FilmService and FilmUseCase as domain service and application service
Add duration serialization
Karat120
force-pushed
the
add-database
branch
from
583a098 to
0b8ebb6
Compare
Karat120
force-pushed
the
add-database
branch
from
0b8ebb6 to
7fde6fe
Compare
litvitnik
reviewed
Nov 15, 2025
|
|
||
| @Service | ||
| @AllArgsConstructor | ||
| public class FilmUseCase { |
There was a problem hiding this comment.
Лучше переименовать этот класс на FilmService, так как это принято в общепринятой практике)
С другими классами сервисами аналогично)
| public class MpaUseCase { | ||
| private final MpaStorage mpaStorage; | ||
|
|
||
| public Mpa add(Mpa mpa) { |
There was a problem hiding this comment.
Такого метода не должно быть по ТЗ. Нужно оставить только два метода getById и getAll
| public class GenreUseCase { | ||
| private final GenreStorage genreStorage; | ||
|
|
||
| public Genre add(Genre genre) { |
There was a problem hiding this comment.
Тута также как и с рейтингом, должны быть только методы getById(Long id) и getAll()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.