Bugfix - Support devices only having mode heat_cool instead of heat (#1322) #1533
Conversation
|
Not tested yet, based this now on the v1.7.0b1 branch (still dunno which version to work on rly) Update: To be tested by @Sir-Udo (testing fix in helpers.py with HEAT_COOL-only TRV) |
|
Hi, |
| trv_modes = self.real_trvs[entity_id]["hvac_modes"] | ||
| if not HVACMode.HEAT in trv_modes and HVACMode.HEAT_COOL in trv_modes: | ||
| # entity only supports HEAT_COOL, but not HEAT - need to translate | ||
| if not inbound and hvac_mode = HVACMode.HEAT: |
There was a problem hiding this comment.
Shouldn't it be equal == instead of =
?
There was a problem hiding this comment.
Oh definitely, thanks - been jumping between projects with different languages too much apparently 😅
| trv_modes = self.real_trvs[entity_id]["hvac_modes"] | ||
| if not HVACMode.HEAT in trv_modes and HVACMode.HEAT_COOL in trv_modes: | ||
| # entity only supports HEAT_COOL, but not HEAT - need to translate | ||
| if not inbound and hvac_mode = HVACMode.HEAT: |
There was a problem hiding this comment.
Oh definitely, thanks - been jumping between projects with different languages too much apparently 😅
|
@folfy There was a typo error on the if statement, and the linting was not correct, i'll fix it, thank you so much for your work! |
KartoffelToby
merged commit 57c852b
into
KartoffelToby:feature/ha_compatibility
Motivation:
Fix #1322 - Support devices only having mode
heat_cool, but notheatChanges:
(this seemed to be easiest and fastest solution for now)
Related issue (check one):
BT device unavailable after creating it or rebooting HA #1336
bt unavailable #1396
Siterwell TRV GS361A-H04 (zivfvd7h) Stop work after update to HA 2024.10.1 #1409
After Restart from HA all Thermostats are offline #1531
Checklist (check one):
Test-Hardware list (for code changes)
HA Version: 2024.12.1
Zigbee2MQTT Version:
TRV Hardware: