Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement set_preset_mode to fix HA scenes using BT (Fixes #1186) #1564

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Kishi85
Copy link

@Kishi85 Kishi85 commented Jan 11, 2025

Motivation:

Enable BT to be used in scenes again

Changes:

Add missing function to allow scenes to be created with BT devices in it

Related issue (check one):

Checklist (check one):

  • I did not change any code (e.g. documentation changes)
  • The code change is tested and works locally.

Test-Hardware list (for code changes)

HA Version: 2025.1.2
Zigbee2MQTT Version:
TRV Hardware:

New device mappings

  • I avoided any changes to other device mappings
  • There are no changes in climate.py

@folfy
Copy link
Collaborator

folfy commented Jan 12, 2025

Looks good for fixing the issue from SERVICE_SET_PRESET_MODE, but I'm not sure why HA would try SERVICE_SET_HUMIDITY (as reported initially in the bug report)

@Kishi85
Copy link
Author

Kishi85 commented Jan 12, 2025

Looks good for fixing the issue from SERVICE_SET_PRESET_MODE, but I'm not sure why HA would try SERVICE_SET_HUMIDITY (as reported initially in the bug report)

I've noted a warning regarding setting humidity pop up on saving a scene with the fix applied locally once while testing (might have been there every time but I've not paid that much attention). Maybe a scene tries to save/restore all state attributes for an entity hence the warning as humidity is in there?

P.S. Looking at the details the validate with hassfest failure does not seem to be related to this change so I can't do anything on my side to resolve it

@KartoffelToby
Copy link
Owner

hassfest validation has an bug Insider the test Container image. No issue on our side just ignore it. There is an open issue on the ha side

@folfy
Copy link
Collaborator

folfy commented Jan 12, 2025

@KartoffelToby I know, just can't merge it because the commit isn't signed. And also wanted to test it myself before :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error about not supported service call when used in a scene
3 participants