Recursively look for feature files to check type#165
Merged
mducducd merged 1 commit intoKatherLab:mainfrom Mar 26, 2026
Merged
Conversation
Collaborator
|
Good catch, I agree. |
mducducd
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
When generating the features of a set of WSIs in a folder with the following structure:
the preprocessing pipeline puts the features in the original folder structure. However, when one tries to run cross validation on a task using those features, the pipeline checks for the feature type by inspecting the root folder only. This throws the error: "No .h5 feature files found in feature_dir.".