feat: Implement automatic session timeout for HIPAA compliance#115
Open
yadavchiragg wants to merge 38 commits intoKathiraveluLab:mainfrom
Open
feat: Implement automatic session timeout for HIPAA compliance#115yadavchiragg wants to merge 38 commits intoKathiraveluLab:mainfrom
yadavchiragg wants to merge 38 commits intoKathiraveluLab:mainfrom
Conversation
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
…tom 404, 403, 500 error pages- Beautiful responsive error UI with animations- User-friendly error messages and suggestions- Added 413 file size error handler- Improved error page structure with base template- Error pages work independently of main site
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Code Review
This pull request dockerizes the application, adds a comprehensive test suite, and introduces an admin dashboard for managing users and images. While the additions are significant, several critical issues need addressing. The session timeout logic is currently inactive as it is not imported, and the application is configured to run in debug mode, which is a security vulnerability for production. Performance improvements are needed for admin queries to avoid N+1 issues and implement pagination. Furthermore, the PR contains code duplication with an unused admin blueprint, hardcoded credentials in scripts, and missing dependencies that cause test failures.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Implements automatic session timeout after 15 minutes of inactivity, addressing HIPAA §164.312(a)(2)(iii) Technical Safeguard requirements for healthcare applications.
Motivation
Healthcare applications handling PHI (Protected Health Information) must implement automatic logoff to prevent unauthorized access from unattended workstations. This is a mandatory HIPAA requirement for production deployment.
Implementation
Backend Security
Frontend UX
/pingroute maintains session without full page reloadTesting
Security Benefits
Healthcare Context
Essential for BHV deployment in healthcare networks:
Files Changed
bhv/app.py: Session configuration, timeout logic, and/pingendpointtemplates/base.html: Inline JavaScript for timeout detection and warningstests/test_session_timeout.py: Comprehensive test coverageREADME.md: Security features documentationTesting Instructions
Related
Checklist