Fix: use correct API route for audio requests#636
Open
iprasannamb wants to merge 6 commits intoKathiraveluLab:devfrom
Open
Fix: use correct API route for audio requests#636iprasannamb wants to merge 6 commits intoKathiraveluLab:devfrom
iprasannamb wants to merge 6 commits intoKathiraveluLab:devfrom
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the audio fetching logic to use the /api/audio/ endpoint and introduces error handling and state management for the ProtectedAudio component. Feedback focuses on preventing memory leaks in useEffect by using a cancellation flag and ensuring that filenames are properly encoded when constructing API endpoints to handle special characters.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Contributor
Author
|
@pradeeban , Could you please review this ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
/audio/:filenameinstead of/api/audio/:filename)Changes
/audio/:filenameto/api/audio/:filenamein ProtectedRoutes component.Checklist: