fix: resolve function collision #87 and implement global error handli…#88
fix: resolve function collision #87 and implement global error handli…#88Nuwan128 wants to merge 8 commits intoKathiraveluLab:mainfrom
Conversation
There was a problem hiding this comment.
Code Review
This pull request refactors the DICOM album application by implementing a base template with Bootstrap 5 styling, improving path management, and adding robust error handling with flash messages. Key functional additions include the implementation of the album-saving logic and session-based query results. The review feedback identifies critical path traversal vulnerabilities in file uploads and album naming, and suggests preventing data corruption by handling existing album directories.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request refactors the DICOM album creation tool by introducing a base template with Bootstrap 5 styling, improving directory management with absolute paths, and adding comprehensive error handling and user feedback via flash messages. Key improvements include a more structured multi-step workflow for uploading and querying DICOM metadata. However, several issues were identified: a missing import for secure_filename will cause a runtime error during file uploads, storing large DataFrames in the Flask session may exceed cookie size limits, and flash messages are being injected into JavaScript without proper escaping, posing a security risk.
|
@Nuwan128 Pls check the bot comments above. |
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
…into fix-core-and-ui
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request refactors the DICOM album creation tool by introducing a centralized base template with Bootstrap 5, improving the user interface, and adding input validation and error handling. Key changes include the use of secure_filename for uploads, session-based state management, and structured directory handling. Review feedback highlights a potential for filename collisions during upload, performance inefficiencies due to redundant DICOM processing in the results view, and the need for more consistent error handling across routes.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
…ng #55