Skip to content

fix: resolve function collision #87 and implement global error handli…#88

Draft
Nuwan128 wants to merge 8 commits intoKathiraveluLab:mainfrom
Nuwan128:fix-core-and-ui
Draft

fix: resolve function collision #87 and implement global error handli…#88
Nuwan128 wants to merge 8 commits intoKathiraveluLab:mainfrom
Nuwan128:fix-core-and-ui

Conversation

@Nuwan128
Copy link
Copy Markdown

…ng #55

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the DICOM album application by implementing a base template with Bootstrap 5 styling, improving path management, and adding robust error handling with flash messages. Key functional additions include the implementation of the album-saving logic and session-based query results. The review feedback identifies critical path traversal vulnerabilities in file uploads and album naming, and suggests preventing data corruption by handling existing album directories.

Comment thread dicom-album-env/app.py Outdated
Comment thread dicom-album-env/app.py
Comment thread dicom-album-env/app.py Outdated
Nuwan128 and others added 2 commits March 29, 2026 17:58
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@pradeeban
Copy link
Copy Markdown
Member

/gemini review

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the DICOM album creation tool by introducing a base template with Bootstrap 5 styling, improving directory management with absolute paths, and adding comprehensive error handling and user feedback via flash messages. Key improvements include a more structured multi-step workflow for uploading and querying DICOM metadata. However, several issues were identified: a missing import for secure_filename will cause a runtime error during file uploads, storing large DataFrames in the Flask session may exceed cookie size limits, and flash messages are being injected into JavaScript without proper escaping, posing a security risk.

Comment thread dicom-album-env/app.py
Comment thread dicom-album-env/app.py Outdated
Comment thread dicom-album-env/templates/base.html Outdated
@pradeeban
Copy link
Copy Markdown
Member

@Nuwan128 Pls check the bot comments above.

@pradeeban pradeeban marked this pull request as draft April 2, 2026 06:01
Nuwan128 and others added 3 commits April 5, 2026 00:07
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@pradeeban pradeeban marked this pull request as ready for review April 5, 2026 02:59
@pradeeban
Copy link
Copy Markdown
Member

/gemini review

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the DICOM album creation tool by introducing a centralized base template with Bootstrap 5, improving the user interface, and adding input validation and error handling. Key changes include the use of secure_filename for uploads, session-based state management, and structured directory handling. Review feedback highlights a potential for filename collisions during upload, performance inefficiencies due to redundant DICOM processing in the results view, and the need for more consistent error handling across routes.

Comment thread dicom-album-env/app.py
Comment thread dicom-album-env/app.py Outdated
Comment thread dicom-album-env/app.py Outdated
@pradeeban pradeeban marked this pull request as draft April 5, 2026 03:03
NuwanDev128 and others added 2 commits April 15, 2026 13:00
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants