Handle different EOL formats when loading data#190
Open
Cogito wants to merge 1 commit intoKazetsukai:masterfrom
Open
Handle different EOL formats when loading data#190Cogito wants to merge 1 commit intoKazetsukai:masterfrom
Cogito wants to merge 1 commit intoKazetsukai:masterfrom
Conversation
When cloning the data files with git the line endings can be changed depending on git autocrlf settings. If there are any carriage returns the parsing fails, so we need to either avoid them or strip them. This change, stripping the carriage returns in addition to the line feeds, is the simplest and has the benefit of also handling any future situation where carriage returns are added to the source files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When cloning the data files with git the line endings can be changed depending on git autocrlf settings.
If there are any carriage returns the parsing fails, so we need to either avoid them or strip them.
This change, stripping the carriage returns in addition to the line feeds, is the simplest and has the
benefit of also handling any future situation where carriage returns are added to the source files.