feat(web): show Product Hunt badge on welcome - #2781
Merged
Conversation
Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the Product Hunt featured badge to the welcome guide so new users see it on first visit (and anyone who reopens the welcome guide).
The official embed is a native link + image with a visible focus ring. It sits in a full-width row under the intro copy so it centers in the modal (the welcome panel uses
items-start, which left-aligned a nested badge).Simplicity
One
ProductHuntBadgecomponent and a centered row in the existing welcome body. Dropped redundantmx-auto/w-fiton the link after the parent row already centers it. No extra state, effects, or refs.Automated validation
bun run lint: no new findings (10 pre-existing warnings elsewhere).http://localhost:9080— badge loads and is horizontally centered with Start Now.Independent review
Fresh read-only review of
origin/main...HEAD: no confirmed findings. Native link, accessible name from alt, focus ring,noopener noreferrer, no storage/event-data changes.Test plan
bun test:web packages/web/src/components/WelcomeModal/WelcomeModal.test.tsx— 11 passbun run lint