Skip to content

Remove ID from biometric list and update-name #1540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
craiglurey merged 1 commit into from
Aug 1, 2025
+0 −11
Merged

Remove ID from biometric list and update-name #1540

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions keepercommander/biometric/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,17 +150,14 @@ biometric list
Registered Biometric Authentication Methods:
----------------------------------------------------------------------
Name: Commander CLI (MacBook)
ID: 12345
Created: December 20, 2023
Last Used: Today
----------------------------------------------------------------------
Name: iCloud Keychain
ID: 67890
Created: December 18, 2023
Last Used: July 10, 2025
----------------------------------------------------------------------
Name: Chrome on Mac
ID: 54321
Created: November 15, 2023
Last Used: Never
----------------------------------------------------------------------
Expand Down Expand Up @@ -240,12 +237,10 @@ Found 2 biometric credential(s) with friendly names
Available Biometric Credentials:
--------------------------------------------------
1. Commander CLI (MacBook)
ID: 12345
Created: January 15, 2024
Last Used: Today

2. Commander CLI (Desktop)
ID: 67890
Created: January 10, 2024
Last Used: January 18, 2024

Expand All @@ -258,7 +253,6 @@ New name: Personal MacBook

Update Summary:
--------------------
ID: 12345
Current Name: Commander CLI (MacBook)
New Name: Personal MacBook

Expand All @@ -267,7 +261,6 @@ Proceed with update? (y/n): y
Passkey Update Results:
==============================
Status: Success
ID: 12345
Old Name: Commander CLI (MacBook)
New Name: Personal MacBook
Message: Passkey friendly name was successfully updated
Expand Down
1 change: 0 additions & 1 deletion keepercommander/biometric/commands/list.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,6 @@ def _display_credentials(self, passkeys):
display_name = provider_name

print(f"Name: {display_name}")
print(f"ID: {passkey['id']}")
print(f"Created: {created_date}")
print(f"Last Used: {last_used_date}")
print("-" * 70)
3 changes: 0 additions & 3 deletions keepercommander/biometric/commands/update_name.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,6 @@ def _interactive_credential_selection(self, available_credentials):
last_used = self._format_timestamp(credential.get('last_used'))

print(f"{i:2}. {credential['name']}")
print(f" ID: {credential['id']}")
print(f" Created: {created_date}")
print(f" Last Used: {last_used}")
print()
Expand Down Expand Up @@ -128,7 +127,6 @@ def _confirm_update(self, credential, new_name):
"""Confirm the update operation"""
print("\nUpdate Summary:")
print("-" * 20)
print(f"ID: {credential['id']}")
print(f"Current Name: {credential['name']}")
print(f"New Name: {new_name}")
print()
Expand All @@ -143,7 +141,6 @@ def _report_update_results(self, result, credential, new_name):
status_code = result['status']
status_text = get_status_message(status_code)
print(f"Status: {status_text}")
print(f"ID: {credential['id']}")
print(f"Old Name: {credential['name']}")
print(f"New Name: {new_name}")
print(f"Message: {result['message']}")
Expand Down